Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute): create sample for Disk Async Replication feature #770

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

ujjwalranjan1
Copy link
Contributor

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@ujjwalranjan1 ujjwalranjan1 requested review from a team as code owners December 3, 2024 09:25
Copy link

snippet-bot bot commented Dec 3, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@msampathkumar msampathkumar changed the title Bug 381228167- Create Terraform sample For Compute Disk Async Replication feat(compute): create sample for Disk Async Replication feature Dec 3, 2024
Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work. Please wait for the CICD to pass before merging!

@msampathkumar
Copy link
Contributor

/gcbrun

@glasnt glasnt enabled auto-merge (squash) December 9, 2024 06:20
@glasnt
Copy link
Contributor

glasnt commented Dec 10, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Dec 10, 2024

Sample is correct and tests successfully, unrelated error in CI ( #778 )

@glasnt glasnt disabled auto-merge December 10, 2024 03:12
@glasnt glasnt merged commit 3a28d6c into terraform-google-modules:main Dec 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants