Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sample for grpc startup probe #554

Merged
merged 3 commits into from
Jan 2, 2024
Merged

feat: add sample for grpc startup probe #554

merged 3 commits into from
Jan 2, 2024

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Dec 11, 2023

Description

Fixes b/315103435

This sample is untestable using the hello container, because it does not implement grpc healthchecks. (The grpc liveness probe sample does not override the startup probe, so it successfully deploys. Since this is a startup probe, the deployment will fail, so it is untestable using the default image.)

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

@glasnt glasnt marked this pull request as ready for review December 11, 2023 21:49
@glasnt glasnt requested review from a team as code owners December 11, 2023 21:49
Copy link

snippet-bot bot commented Dec 11, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt glasnt assigned glasnt and unassigned glasnt Dec 12, 2023
Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glasnt
Copy link
Contributor Author

glasnt commented Jan 1, 2024

/gcbrun

@glasnt glasnt merged commit 12fe0c2 into main Jan 2, 2024
9 checks passed
@apeabody apeabody deleted the grcp-startup branch June 4, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants