Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Workflows snippet #550

Merged
merged 15 commits into from
Jan 17, 2024
Merged

docs: Add Workflows snippet #550

merged 15 commits into from
Jan 17, 2024

Conversation

camiekim
Copy link
Contributor

@camiekim camiekim commented Dec 6, 2023

Description

Fixes b/265819420

Intending to use this snippet on the following page:
Staged: https://cloud.devsite.corp.google.com/workflows/docs/tutorials/execute-cloud-run-jobs

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@camiekim camiekim requested review from a team as code owners December 6, 2023 20:20
Copy link

snippet-bot bot commented Dec 6, 2023

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@pattishin pattishin self-requested a review December 16, 2023 01:14
Copy link
Contributor

@pattishin pattishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @camiekim! Just added a few comments - let me know if there is anywhere I can clarify.

workflows/cloud_run_job/main.tf Outdated Show resolved Hide resolved
workflows/cloud_run_job/main.tf Outdated Show resolved Hide resolved
workflows/cloud_run_job/main.tf Outdated Show resolved Hide resolved
@msampathkumar
Copy link
Contributor

/gcbrun

@iennae
Copy link
Contributor

iennae commented Jan 13, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Jan 15, 2024

Manually verified staged tutorial, works as given. One minor correction to apply before approval/merge.

@glasnt
Copy link
Contributor

glasnt commented Jan 15, 2024

/gcbrun

@pattishin
Copy link
Contributor

/gcbrun

@glasnt glasnt enabled auto-merge (squash) January 17, 2024 00:41
Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glasnt glasnt merged commit 93c9a3c into terraform-google-modules:main Jan 17, 2024
5 checks passed
@camiekim camiekim deleted the bug-265819420 branch March 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants