Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute): update wildcard format in os_version #547

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix(compute): update wildcard format in os_version #547

merged 2 commits into from
Dec 6, 2023

Conversation

savijatv
Copy link

@savijatv savijatv commented Dec 5, 2023

Update wildcard format in os_version in terraform sample

Although the os policy assignment rollout was successful, the policy wasn't applied on VMs. As per the suggestion from eng team, changed the wildcard format to match all operating systems with the version provided.

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

… sample

Although the os policy assignment rollout was successful, the policy wasn't applied on VMs. As per the suggestion from eng team, changed the wildcard format to match all operating systems with the version provided.
@savijatv savijatv requested review from a team as code owners December 5, 2023 15:13
Copy link

conventional-commit-lint-gcf bot commented Dec 5, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@savijatv
Copy link
Author

savijatv commented Dec 5, 2023

/gcbrun

@savijatv savijatv changed the title chore (Compute):Update wildcard format in os_version in the terraform… chore(Compute):Update wildcard format in os_version in the terraform… Dec 5, 2023
@savijatv savijatv changed the title chore(Compute):Update wildcard format in os_version in the terraform… fix(compute):Update wildcard format in os_version in the terraform… Dec 5, 2023
@savijatv
Copy link
Author

savijatv commented Dec 5, 2023

/assign msampathkumar

@msampathkumar
Copy link
Contributor

/gcbrun

@msampathkumar
Copy link
Contributor

Thank you for regularly updating the samples @savijatv

@msampathkumar msampathkumar enabled auto-merge (squash) December 5, 2023 15:55
@msampathkumar
Copy link
Contributor

/gcbrun

@msampathkumar msampathkumar changed the title fix(compute):Update wildcard format in os_version in the terraform… fix(compute): update wildcard format in os_version Dec 6, 2023
@msampathkumar msampathkumar self-assigned this Dec 6, 2023
@msampathkumar msampathkumar merged commit 6358cdb into terraform-google-modules:main Dec 6, 2023
5 checks passed
@savijatv savijatv deleted the patch-2 branch May 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants