Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): include iam bind with service account create #513

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

rogerthatdev
Copy link
Contributor

This PR groups the google_cloud_run_service_iam_member resource with the google_service_account resource so that it can accurately reflect command line and console steps on this page

@rogerthatdev rogerthatdev requested review from a team as code owners October 13, 2023 17:12
@snippet-bot
Copy link

snippet-bot bot commented Oct 13, 2023

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may wait for torus team for another approval.

@rogerthatdev rogerthatdev merged commit ea22aea into main Oct 23, 2023
9 checks passed
msampathkumar pushed a commit to msampathkumar/terraform-docs-samples that referenced this pull request Dec 7, 2023
@apeabody apeabody deleted the run-patch branch June 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants