chore(bigquery): update object table docs #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wj-chen
reviewed
Sep 8, 2023
wj-chen
approved these changes
Sep 9, 2023
rogerthatdev
previously requested changes
Sep 11, 2023
There was a problem hiding this comment.
Please update the Google Cloud resource names to main
See cloud.google.com/docs/terraform/best-practices-for-terraform
|
@nevzheng - friendly reminder! |
|
I'm waiting for input from adhiggs@ |
msampathkumar
changed the title
rogerthatdev
added
waiting-for-codeowners
and removed
waiting-response
|
Thank you for your patience. I'll get to this item this week. |
adhiggs
suggested changes
Oct 12, 2023
nevzheng
force-pushed
the
update-object-table-sample
branch
from
137d6ea to
32cc5d9
Compare
|
@adhiggs We can certainly do so. Let me know what the changes should be. line number + change. |
adhiggs
suggested changes
Oct 13, 2023
msampathkumar
approved these changes
Oct 20, 2023
| */ | ||
|
|
||
| # [START bigquery_create_object_table] | ||
|
|
||
| # This queries the provider for project information. | ||
| data "google_project" "main" {} |
There was a problem hiding this comment.
Suggested change
| data "google_project" "main" {} | |
| data "google_project" "default" {} |
| resource "google_project_iam_member" "default" { | ||
| role = "roles/storage.objectViewer" | ||
| project = data.google_project.project.project_id | ||
| project = data.google_project.main.project_id |
There was a problem hiding this comment.
Suggested change
| project = data.google_project.main.project_id | |
| project = data.google_project.default.project_id |
|
Almost there. As suggested by other reviewer, please check an update the resource name. Added code suggestions for the same. |
msampathkumar
added a commit
to msampathkumar/terraform-docs-samples
that referenced
this pull request
Dec 7, 2023
* update: object table docs * update: fix comment, resource name * update: integrate reviewer feedback * update: integrate reviewer input --------- Co-authored-by: Roger Martinez <[email protected]> Co-authored-by: Sampath Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/bigquery/docs/object-tables#create-object-table
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review