-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudsql): Add postgres samples for enterprise & enterprise_plus edition #491
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
@ibhaskar2 please fix the lint and test errors when you have a chance. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the sample to main.tf
file in the cloud_sql/instance_edition/
directory.
@rogerthatdev please review it, i have made required changes |
@ibhaskar2 Almost there! Use
This format is for all the cloud_sql samples. Some old samples which don't follow this format, need to be updated as well. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/gcbrun
Description
Added documentation for cloud sql instance edition
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):https://cloud.google.com/sql/docs/editions-intro
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review