Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudsql): Add postgres samples for enterprise & enterprise_plus edition #491

Merged
merged 8 commits into from
Sep 27, 2023

Conversation

ibhaskar2
Copy link
Contributor

Description

Added documentation for cloud sql instance edition

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@ibhaskar2 ibhaskar2 requested review from a team as code owners September 7, 2023 07:59
@snippet-bot
Copy link

snippet-bot bot commented Sep 7, 2023

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ibhaskar2 ibhaskar2 changed the title Added documentation for cloud sql instance edition feat:Added documentation for cloud sql instance edition Sep 7, 2023
@gericdong
Copy link
Contributor

@ibhaskar2 please fix the lint and test errors when you have a chance. Thanks.

cloud_sql/instance_edition Outdated Show resolved Hide resolved
@ibhaskar2 ibhaskar2 changed the title feat:Added documentation for cloud sql instance edition feat: Added documentation for cloud sql instance edition Sep 11, 2023
@rogerthatdev rogerthatdev self-assigned this Sep 11, 2023
Copy link
Contributor

@rogerthatdev rogerthatdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the sample to main.tf file in the cloud_sql/instance_edition/ directory.

@rogerthatdev rogerthatdev added the waiting-response Waiting for issue author to respond. label Sep 11, 2023
@ibhaskar2
Copy link
Contributor Author

@rogerthatdev please review it, i have made required changes

@msampathkumar
Copy link
Contributor

msampathkumar commented Sep 18, 2023

@ibhaskar2 Almost there! Use mysql_ and postgres_ prefixes in the folder names.

  • cloud_sql/enterprise_edition_instance/main.tf --> cloud_sql/mysql_enterprise_edition_instance/main.tf

  • cloud_sql/enterprise_plus_edition_instance/main.tf --> cloud_sql/postgres_enterprise_plus_edition_instance/main.tf

This format is for all the cloud_sql samples. Some old samples which don't follow this format, need to be updated as well.

@msampathkumar
Copy link
Contributor

/gcbrun

Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

/gcbrun

@msampathkumar msampathkumar changed the title feat: Added documentation for cloud sql instance edition feat(cloudsql): Add postgres samples for enterprise & enterprise_plus edition Sep 20, 2023
@rogerthatdev rogerthatdev removed the waiting-response Waiting for issue author to respond. label Sep 27, 2023
@rogerthatdev rogerthatdev enabled auto-merge (squash) September 27, 2023 22:44
@rogerthatdev rogerthatdev merged commit ce2be11 into terraform-google-modules:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants