Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelerator_config to google_tpu_v2_vm #581

Conversation

modular-magician
Copy link
Collaborator

b/292585830

Follow-up to GoogleCloudPlatform/magic-modules#9308

This adds accelerator_config, which is a more flexible alternative to accelerator_type. Only one can be specified for creation, but both will be returned by the API.

The notable piece here is that we previously had a client-side default for accelerator_type, so adding the accelerator_config alternative without introducing a breaking change presented a challenge:

  • Since the API does not accept both fields at once, the "v2-8" default needed to be removed, so that accelerator_config could be set.
  • However, to continue supporting config without either of these fields specified the same way (default to "v2-8"), a customize diff was needed to conditionally populate the accelerator_type default.

Release Note Template for Downstream PRs (will be copied)

tpuv2: added`accelerator_config` field to `google_tpu_v2_vm` resource

Derived from GoogleCloudPlatform/magic-modules#9332

[upstream:2601597b36a86aa64e4cdc91c0b746757e45ae73]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 80d1920 into terraform-google-modules:master Oct 23, 2023
1 check passed
@modular-magician modular-magician deleted the downstream-pr-2601597b36a86aa64e4cdc91c0b746757e45ae73 branch November 18, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant