Add remaining fields to TPU VM resource #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Skip generated tests for google_tpu_v2_vm (#9315)" This reverts commit 5dc9f2ea88610c0d2a2a94d04548d60e90e1cc54. * Add remaining fields to TPU VM resource * Change update test to use preemptible vm * Retain disk in test so that it isn't removed prematurely * Add networking fields * Respond to PR comments * More tweaks from PR comments * Tweak test names based on feedback [upstream:b48fc2d24968dc972360eb82c704b4eaeb8b40ba] Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit aadf15d
into
terraform-google-modules:master
1 check passed
modular-magician
deleted the
downstream-pr-b48fc2d24968dc972360eb82c704b4eaeb8b40ba
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/292585830
This adds the remaining fields to
google_tpu_v2_vmthat are available from the API.Notable exceptions (which may end up making it into this PR):
accelerator_configaccelerator_type, and we'll need to work around the existing default behaviorOne other interesting piece is
service_account.scopes. If the user specifies this field but does not includehttps://www.googleapis.com/auth/pubsub, it will be automatically added by the server, so I've added a diff_suppress to ignore that value.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9308