Bridge gap between Terraform and API for AlloyDB #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add display name to backup * Add alll the fields for backup * Fix indentation * Fix indentation * Fix documentation and attribute type * Add attributes for cluster and instance with tests * Remove annotations and displayName as not supported by GET API * Misc * Mark queryInsightsConfig as default_from_api instead of its sub-fields * Mark Backup type as default_from_api * Delete ignore_only section in alloydb_backup_basic * Re-run tests * Comment out tests failing due to networking service bug Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit cbb5c23
into
terraform-google-modules:master
1 check passed
modular-magician
deleted the
downstream-pr-9838777ae9e75d79e67a401129f9783473be1fa5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.This PR contains multiple changes for AlloyDB cluster, instance, and backup. It adds all the attributes which were missing in Terraform but were present in REST API for these resources and the corresponding tests.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8781