fix: Add primary_ipv6 parameter to self-managed-node-group
#3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmtsi
changed the title
jmtsi
changed the title
bryantbiggs
changed the title
primary_ipv6 parameter to self-managed-node-group
bryantbiggs
approved these changes
Oct 3, 2024
bryantbiggs
merged commit fef6555
into
terraform-aws-modules:master
19 of 20 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Oct 3, 2024
## [20.24.3](v20.24.2...v20.24.3) (2024-10-03) ### Bug Fixes * Add `primary_ipv6` parameter to self-managed-node-group ([#3169](#3169)) ([fef6555](fef6555))
|
This PR is included in version 20.24.3 🎉 |
|
Wow, thanks for the quick reaction to my PR! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The launch template config in self-managed-node-group didn't include the parameter to set
primary_ipv6, so I add it here. This has already been implemented for eks-managed-node-group in this PRMotivation and Context
This parameter is needed to enable
Assign primary IPv6 IPfor self-managed-node-group nodes. This is required to make it possible to use instance-type targets when using IPv6 and AWS Load Balancer ControllerBreaking Changes
Simple addition, no breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request