Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support aws_cloudwatch_log_account_policy #71

Merged

Conversation

magreenbaum
Copy link
Member

Description

Support cloudwatch log account policies.

Motivation and Context

hashicorp/terraform-provider-aws#38328
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/mask-sensitive-log-data-accountlevel.html
https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-cloudwatch-logs-account-level-subscription-filter/
https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-cloudwatch-logs-data-protection-policy-configuration/

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum changed the title feat: Support log account policy feat: Support cloudwatch log account policy Jul 14, 2024
@magreenbaum magreenbaum changed the title feat: Support cloudwatch log account policy feat: Support aws_cloudwatch_log_account_policy Jul 16, 2024
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, and LGTM.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Anton Babenko <[email protected]>
README.md Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit 1842707 into terraform-aws-modules:master Aug 9, 2024
12 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 9, 2024
## [5.5.0](v5.4.0...v5.5.0) (2024-08-09)

### Features

* Support `aws_cloudwatch_log_account_policy` ([#71](#71)) ([1842707](1842707))
@antonbabenko
Copy link
Member

This PR is included in version 5.5.0 🎉

@magreenbaum magreenbaum deleted the feat/log_account_policy branch August 9, 2024 23:56
Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants