feat: Add option to define a delimiter for metric-alarms-by-multiple-dimensions #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option to define a delimiter between alarm name and dimension key for
metric-alarms-by-multiple-dimensions
Motivation and Context
While creating multiple alerts I noticed that there is no delimiter between common prefix and dimension resource name, so I had to prefix them by space character:
" ${local.project.name}-postgres-${local.env}"
and this does not look so pretty:
Breaking Changes
None, default value falls back to previous behaviour.
How Has This Been Tested?
There are no examples that use
metric-alarms-by-multiple-dimensions
, so I tested it only on my local project.examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request