Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to define a delimiter for metric-alarms-by-multiple-dimensions #66

Merged

Conversation

caseycs
Copy link
Contributor

@caseycs caseycs commented Feb 23, 2024

Description

Add option to define a delimiter between alarm name and dimension key for metric-alarms-by-multiple-dimensions

Motivation and Context

While creating multiple alerts I noticed that there is no delimiter between common prefix and dimension resource name, so I had to prefix them by space character:

" ${local.project.name}-postgres-${local.env}"

and this does not look so pretty:

inputs = {
    items = {
        rds-cpu-usage = {
...
            dimensions = {
                " ${local.project.name}-postgres-${local.env}" = {
                   DBClusterIdentifier = "${local.project.name}-postgres-${local.env}" 
                }
            }
...
        }
...

Breaking Changes

None, default value falls back to previous behaviour.

How Has This Been Tested?

There are no examples that use metric-alarms-by-multiple-dimensions, so I tested it only on my local project.

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@caseycs caseycs marked this pull request as ready for review February 23, 2024 23:42
@caseycs caseycs changed the title feat: Add option to define a delimiter betwen alarm name and dimensio… feat: Add option to define a delimiter between alarm name and dimension Feb 23, 2024
@caseycs caseycs changed the title feat: Add option to define a delimiter between alarm name and dimension feat: Add option to define a delimiter for metric-alarms-by-multiple-dimensions Feb 23, 2024
@antonbabenko antonbabenko merged commit 0959943 into terraform-aws-modules:master Feb 26, 2024
39 checks passed
antonbabenko pushed a commit that referenced this pull request Feb 26, 2024
## [5.3.0](v5.2.0...v5.3.0) (2024-02-26)

### Features

* Add option to define a delimiter for metric-alarms-by-multiple-dimensions ([#66](#66)) ([0959943](0959943))
@antonbabenko
Copy link
Member

This PR is included in version 5.3.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants