Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support aws_cloudwatch_query_definition and add skip_destroy argument to aws_cloudwatch_log_group #60

Conversation

magreenbaum
Copy link
Member

Description

Support aws_cloudwatch_query_definition and add skip_destroy argument to aws_cloudwatch_log_group.

Motivation and Context

Closes: #59
Closes: #58

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link

github-actions bot commented Dec 8, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 8, 2023
@magreenbaum
Copy link
Member Author

Unstale

@github-actions github-actions bot removed the stale label Dec 9, 2023
modules/log-group/variables.tf Outdated Show resolved Hide resolved
modules/query-definition/versions.tf Outdated Show resolved Hide resolved
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work, thank you!

@bryantbiggs bryantbiggs merged commit 5cc5efb into terraform-aws-modules:master Dec 12, 2023
29 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 12, 2023
## [4.5.0](v4.4.0...v4.5.0) (2023-12-12)

### Features

* Support `aws_cloudwatch_query_definition` and add `skip_destroy` argument to `aws_cloudwatch_log_group` ([#60](#60)) ([5cc5efb](5cc5efb))
@antonbabenko
Copy link
Member

This PR is included in version 4.5.0 🎉

@magreenbaum magreenbaum deleted the feat/query_definition_and_skip_destroy_param branch January 6, 2024 05:50
Copy link

github-actions bot commented Feb 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support skip_destroy parameter on cloudwatch_log_group Support for aws_cloudwatch_query_definition
3 participants