Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow setting dimensions on CloudWatch Metric Filters #57

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: Allow setting dimensions on CloudWatch Metric Filters #57

merged 1 commit into from
Dec 11, 2023

Conversation

LawrenceWarren
Copy link
Contributor

Description

  • Create a new variable, metric_transformation_dimensions, that is a map of strings (e.g., { "str" = "str" })
  • Use metric_transformation_dimensions to set the metric_transformation.dimensions attribute on the aws_cloudwatch_log_metric_filter resource
  • Update description of the metric_transformation_default_value variable to reflect it's conflict with metric_transformation_dimensions
  • Regenerate README.md

Motivation and Context

  • In my company, we want to capture our custom metrics in Terraform
  • Our metrics set custom dimensions
  • This module does everything we need except setting custom dimensions
  • I have made this change so this module does everything we need

Breaking Changes

N/A

How Has This Been Tested?

  • We have deployed our forked module and imported existing metrics into it with no side effects

@LawrenceWarren LawrenceWarren changed the title Feature: allow setting dimensions on CloudWatch Metric Filters feat: allow setting dimensions on CloudWatch Metric Filters Sep 11, 2023
@LawrenceWarren LawrenceWarren changed the title feat: allow setting dimensions on CloudWatch Metric Filters feat: Allow setting dimensions on CloudWatch Metric Filters Sep 11, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 12, 2023
@LawrenceWarren
Copy link
Contributor Author

Keep this PR open!

@LawrenceWarren
Copy link
Contributor Author

@antonbabenko can I get a review?

@github-actions github-actions bot removed the stale label Oct 17, 2023
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 16, 2023
@LawrenceWarren
Copy link
Contributor Author

Not stale! Keep open!

@github-actions github-actions bot removed the stale label Nov 17, 2023
@bryantbiggs bryantbiggs merged commit 72084b3 into terraform-aws-modules:master Dec 11, 2023
2 of 4 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
@semantic-release-bot
chore(release): version 4.4.0 [skip ci]
81f852a 
## [4.4.0](v4.3.0...v4.4.0) (2023-12-11)

### Features

* Allow setting dimensions on CloudWatch Metric Filters ([#57](#57)) ([72084b3](72084b3))
@antonbabenko
Copy link
Member

This PR is included in version 4.4.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LawrenceWarren @antonbabenko @bryantbiggs