Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump aws provider to 5.0 #148

Closed
wants to merge 1 commit into from

Conversation

lays147
Copy link

@lays147 lays147 commented Mar 1, 2024

Description

I need some terraform features that are only available in terraform 5.0, and I'm unable to use it because of this module provider version. So I'm opening this PR to bump it to 5.0

Motivation and Context

Conflicts between the provider configuration of the module and of my project

Breaking Changes

It appears that does not break anything, since I used my fork's version in my project and no changes to the ACM config were found.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@lays147 lays147 changed the title feat: bump aws provider to 5.0 Feat: bump aws provider to 5.0 Mar 1, 2024
@lays147 lays147 changed the title Feat: bump aws provider to 5.0 feat: Bump aws provider to 5.0 Mar 1, 2024
Signed-off-by: Lays Rodrigues <[email protected]>
@antonbabenko
Copy link
Member

This module requires AWS provider 4.40+, so you should be able to use any newer version of AWS provider without the need to bump the version of the provider here.

We will bump the version of the provider in the module as soon as we implement features that are available only in the newer version of AWS provider. We already require minimum version of Terraform AWS provider in the module.

Copy link

github-actions bot commented Apr 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants