Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(main/golang): 1.23.4 #22817

Merged
merged 1 commit into from
Jan 9, 2025
Merged

bump(main/golang): 1.23.4 #22817

merged 1 commit into from
Jan 9, 2025

Conversation

okhex
Copy link
Contributor

@okhex okhex commented Jan 9, 2025

No description provided.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TomJo2000
Copy link
Member

TomJo2000 commented Jan 9, 2025

Actually I'd like to sneak a couple fixup changes to the build script in here while we're at it.

The "# Use the ~ deb versioning construct in the future:" comment was made 9 years ago in reference to Go version 1.6 needing to be considered a higher version than 1.6rc1.
We have since stopped shipping release candidates of Golang, so this comment no longer applies.

The _MAJOR_VERSION as a separate variable is also archaic and unused so that can just be put into the package version itself.
I'll push an amended commit to this branch shortly.

Drop obsolete comment regarding rc versions.
Drop use of a separate `_MAJOR_VERSION` variable as it is unused.
Co-authored-by: TomIO <[email protected]>
@TomJo2000 TomJo2000 merged commit 4c621e6 into termux:master Jan 9, 2025
8 checks passed
@okhex okhex deleted the golang-1.23.4 branch January 9, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants