fix(main/cvs): fix build without editor #21900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJo2000
reviewed
Oct 20, 2024
|
@robertkirkman Thanks! Can you squash the three commits into a single |
Fixes "`Failed to find a text file editor. CVS cannot be compiled without a default log message editor.`" during build (within the official termux builder docker image using `scripts/run-docker.sh ./build-package.sh -f cvs`) Based on code copied from https://gitlab.com/buildroot.org/buildroot/-/commit/1455d5241b288770aeea7f5ba6dcd1ea31966ba1
robertkirkman
force-pushed
the
cvs-fix-build-without-editor
branch
from
96202e6 to
cf31c03
Compare
|
Yes sure! I hope that it is changed correctly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "
Failed to find a text file editor. CVS cannot be compiled without a default log message editor." during build (within the official termux builder docker image usingscripts/run-docker.sh ./build-package.sh -f cvs)Based on code copied from https://gitlab.com/buildroot.org/buildroot/-/commit/1455d5241b288770aeea7f5ba6dcd1ea31966ba1