Fix route loading in Contao 4.13 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
reviewed
Nov 26, 2024
|
Have you confirmed this works locally? It does not work for me in Contao 5.4 with Symfony 7. There is no Annotation loader in Symfony 7 anymore (by default). |
fritzmg
requested changes
Nov 26, 2024
There was a problem hiding this comment.
With this PR the following error occurs under Contao 5.4 with Symfony 7:
bin/console debug:router nc_bulky_item_download
13:02:49 CRITICAL [console] Error thrown while running command "debug:router nc_bulky_item_download". Message: "The route "nc_bulky_item_download" does not exist."
As far as I can see this is just there to re-use the FQCN of the old |
|
Fixed in 80b942d |
fritzmg
approved these changes
Nov 26, 2024
|
This made me realize I had the same issue in |
|
Yeah, looking forward to Contao 4.13 EOL in February 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stay compatible with Contao 4.13/Symfony 5, you cannot use attributes for route loading (since they were added in Symfony 6). But the annotation still works in Symfony 6 and 7.