Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boolean compatibility for Contao 4 #350

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix boolean compatibility for Contao 4 #350

merged 2 commits into from
Jul 17, 2024

Conversation

de-es
Copy link
Contributor

@de-es de-es commented Jul 5, 2024

Closes #341

fritzmg
fritzmg requested changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to not set $objRecipient->active = false; (or '') at all. The database default is already false.

@fritzmg fritzmg added the bug label Jul 5, 2024
@fritzmg fritzmg mentioned this pull request Jul 5, 2024
Closed
@Toflar Toflar merged commit b14e32d into terminal42:main Jul 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzmg fritzmg fritzmg approved these changes

@Toflar Toflar Toflar approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrity constraint violation while subscribing to newsletter
3 participants
@de-es @Toflar @fritzmg