Do not modify the original NavigationItem if generating URL fails

terminal42 · Aug 29, 2024 · 89761f7 · 89761f7
1 parent 688fa97
commit 89761f7
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/Navigation/NavigationItem.php b/src/Navigation/NavigationItem.php
@@ -177,11 +177,12 @@ public function getHref(UrlParameterBag $urlParameterBag, bool $catch = false):
                 throw $e;
             }
 
-            $this->targetPage = null;
-            $this->isDirectFallback = false;
-            $this->isCurrentPage = false;
+            $clone = clone $this;
+            $clone->targetPage = null;
+            $clone->isDirectFallback = false;
+            $clone->isCurrentPage = false;
 
-            return $this->getHref($urlParameterBag);
+            return $clone->getHref($urlParameterBag);
         }
 
         if (null !== ($queryString = $urlParameterBag->generateQueryString())) {