@ #440 | more correct way to check branch #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
datphan
changed the title
datphan
changed the title
|
@phuonglm @hieptranquoc please review this asap |
hieptranquoc
approved these changes
Sep 13, 2018
hoatle
reviewed
Sep 13, 2018
| @@ -130,11 +131,14 @@ def check_branch(current_ref, desired_branch) | |||
|
|
|||
| @logger.debug("current_branch: #{current_branch} - desired_branch: #{desired_branch}") | |||
|
|
|||
| local_branch = `git branch -a | grep -v "HEAD detached" | grep -r "#{desired_branch}"`.strip | |||
There was a problem hiding this comment.
I don't think this is the proper way to get the local branch:
teracy-dev hoatle$ git branch -a | grep -v "HEAD detached" | grep -r "develop"
(standard input):* develop
(standard input): remotes/datphan/develop
(standard input): remotes/origin/HEAD -> origin/develop
(standard input): remotes/origin/develop
(standard input): remotes/upstream/develop
There was a problem hiding this comment.
It is a check for desired branch, not to get it, it is more correct than the current way,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to resolve some issues like branch name contains
\or ref is atdetached HEADconnect #440