Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should improve gitsynch performance #465

Open
hoatle opened this issue Sep 1, 2018 · 5 comments
Open

should improve gitsynch performance #465

hoatle opened this issue Sep 1, 2018 · 5 comments

Comments

@hoatle
Copy link
Member

hoatle commented Sep 1, 2018

The current performance is not good enough, it takes time to check and sync.

I guess we can improve its performance by:

git checkout #{branch} -b #{branch}

And use current branch with desired branch to compare if we need to update when they're different.

Currently, we use ref to check, I guess it's the cause of slowness.

@hoatle
Copy link
Member Author

hoatle commented Sep 1, 2018

make sure go add measurement to see how much performance is gained with the changes.

@datphan
Copy link
Contributor

datphan commented Sep 22, 2018

This process takes time because of the git fetch origin command, the other commands do not take any visible time, and I couldn't found any way to improve it except make the git fetch origin only run after some time pass, like 2 days, 1 weeks, ...

git checkout #{branch} -b #{branch} I'd run it without any differences

@hoatle hoatle assigned phuonglm and unassigned datphan Sep 23, 2018
@hoatle
Copy link
Member Author

hoatle commented Sep 23, 2018

assigned to @phuonglm to see if the performance can be improved.

@hoatle hoatle assigned hoatle and unassigned phuonglm Oct 11, 2018
hoatle added a commit that referenced this issue Oct 12, 2018
@hoatle
Copy link
Member Author

hoatle commented Oct 12, 2018

timer debug logger added, try this to check the timer:

$ LOG_LEVEL=debug LOG_PROGNAME="Extension::Manager|Location::Manager" vagrant status

@hoatle
Copy link
Member Author

hoatle commented Oct 15, 2018

move out of v0.6.0-a5 scope, will address this on beta releases.

@hoatle hoatle removed this from the v0.6.0-a5-dev milestone Oct 15, 2018
@hoatle hoatle added the comp:location location sync label Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants