Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Add custom conditions use cases to the docs #52

Merged
merged 1 commit into from
May 6, 2020

Conversation

myovchev
Copy link
Contributor

@myovchev myovchev commented May 3, 2020

Details

  • Add custom conditions use cases to the docs
  • Add tests for corresponding examples
  • Add version requirements for every use case in the documentation
  • Propose unified terminology to avoid confusion:
    core condition: AND, OR. NOT, etc
    custom condition: declared and registered custom condition conditionName, available in the grand flow as custom:conditionName
    function condition: native JS function, added while defining the grands, not serializeable
  • Expose getValueByPath from condition utils to allow developers to use JSONPath in their custom condition implementations. It's not exposed in the browser build (./app.js), but I'm not sure how it'll affect the bundle size.

Ref: #45

@codeclimate
Copy link

codeclimate bot commented May 3, 2020

Code Climate has analyzed commit 68c4445 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 90.6% (0.0% change).

View more on Code Climate.

README.md Show resolved Hide resolved
@koladilip
Copy link
Contributor

@myovchev Thanks a lot for this change.

@koladilip koladilip merged commit 321d013 into tensult:develop May 6, 2020
@myovchev myovchev deleted the feat/custom-conditions-docs branch May 8, 2020 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants