Enable clang for device/ folder #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
changed the title
joelsmithTT
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
I think ioctl.h should be excluded, not sure how easy that is to do.
Also suggest adding DerivePointerAlignment: false, PointerAlignment: Left, ReferenceAlignment: Left (see https://tenstorrent.slack.com/archives/C07L16Z59AP/p1731099457956649?thread_ts=1731092455.581859&cid=C07L16Z59AP for discussion).
But that can always be done later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #47 , a follow up from #203
Removed device/.clang-format which disabled formatting in this folder, and ran
pre-commit run --all-filesIf there is something you see that is formatted not in the way you like, please leave a comment, we can add
// clang-format offto some block to leave custom formatting.