-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-ethernet-map lib instead of bin #245
Conversation
Can you or @TTDRosen add instructions for generating this new binary and perhaps consider maintaining ARM64 support in UMD (which this change breaks), and possibly adding RISC-V support? There's community interest in the latter and I have hardware setups for both. (I did N150 home trials with an Ampere system and although I never merged the metal support it would be nice if this kept working) |
I am not sure of the appropriate place to put this (someone please advise) but to reduce our bus factor. From luwen root |
Great, thanks @TTDRosen. This change is fine with me provided that |
dfae6f6
to
6d4e180
Compare
6cfe55f
to
f86b0f1
Compare
### Issue Fixes #298 ### Description After #245 the default location of cluster_descriptor.yaml creation has changed. There were some comments from metal and debuda team around this. Mainly, this file is not hidden anymore. On the suggestion from @tt-vjovanovic , I've changed the code to create this file in OS provided temporary directory. ### List of the changes - Put newly created cluster_descriptor.yaml in a temp folder. This won't be relative to working dir anymore. ### Testing CI tests touch this codepath ### API Changes There are no API changes in this PR.
### Issue Fixes #298 ### Description After #245 the default location of cluster_descriptor.yaml creation has changed. There were some comments from metal and debuda team around this. Mainly, this file is not hidden anymore. On the suggestion from @tt-vjovanovic , I've changed the code to create this file in OS provided temporary directory. ### List of the changes - Put newly created cluster_descriptor.yaml in a temp folder. This won't be relative to working dir anymore. ### Testing CI tests touch this codepath ### API Changes There are no API changes in this PR.
Related to #99
This change will simplify our build system changes by a lot. No additional artefacts needed to be shipped with libdevice, and no thinking about relative/absolute path once the lib is built.
@TTDRosen provided this library.
Changes:
The following PR will remove cluster yaml altogether. Both from tt_ClusterDescriptor interface and from tt_SiliconDevice. Didn't want to overwhelm this PR.
This change requires client changes. Breaks existing references to create-ethernet-map binary