Check KMD version prior to querying device info #173
Conversation
joelsmithTT
force-pushed
the
joelsmith/kmd-version-check
branch
from
c42bcf9
to
626cbc2
Compare
joelsmithTT
force-pushed
the
joelsmith/kmd-version-check
branch
from
626cbc2
to
9a8ada8
Compare
| @@ -21,6 +21,7 @@ set(UMD_DEVICE_SRCS | |||
| wormhole/wormhole_coordinate_manager.cpp | |||
| pcie/pci_device.cpp | |||
| hugepage.cpp | |||
| ../common/semver.cpp | |||
There was a problem hiding this comment.
Should we instead compile a common lib, and then make device relying on common lib? @blozano-tt
There was a problem hiding this comment.
I can do that in this PR, but my thought is that we have opportunity for a broader cleanup.. today we have code in:
common/
src/
device/ <- most stuff lives here
I'm not sure what the best way to structure things is. What do you think? I am happy to create a ticket and defer this, equally happy to add a libumdcommon (or some such) for now.. let me know.
There was a problem hiding this comment.
... or we could keep common as header only, and move those small implementations that you have in .cpp file to a .h file as inline functions. Not sure what is the best way to keep things organised. Would like @blozano-tt 's insight here
There was a problem hiding this comment.
My rationale for putting it in .cpp was to keep the fmt include out of the header.
Add semver_t type into common to handle version numbers, based on semver 2.0.0 but more permissive since TT-KMD reports non-compliant version strings like "1.29" and "1.28-bh2". Add logic to PCIDevice class to report KMD version during device initialization.
joelsmithTT
force-pushed
the
joelsmith/kmd-version-check
branch
from
b87b20b
to
d70cd71
Compare
No description provided.