Skip to content

Commit

Permalink
Fix and re-enable most BH unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
vtangTT committed Aug 15, 2024
1 parent 806fb9e commit ac71e20
Show file tree
Hide file tree
Showing 3 changed files with 331 additions and 355 deletions.
2 changes: 1 addition & 1 deletion device/tt_silicon_driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4294,7 +4294,7 @@ void tt_SiliconDevice::broadcast_write_to_cluster(const void *mem_ptr, uint32_t
else if (arch_name == tt::ARCH::BLACKHOLE) {
auto architecture_implementation = tt::umd::architecture_implementation::create(static_cast<tt::umd::architecture>(arch_name));
if(cols_to_exclude.find(0) == cols_to_exclude.end() or cols_to_exclude.find(9) == cols_to_exclude.end()) {
log_assert(!tensix_or_eth_in_broadcast(cols_to_exclude, architecture_implementation.get()), "Cannot broadcast to tensix/ethernet and DRAM simultaneously on Wormhole.");
log_assert(!tensix_or_eth_in_broadcast(cols_to_exclude, architecture_implementation.get()), "Cannot broadcast to tensix/ethernet and DRAM simultaneously on Blackhole.");
if(cols_to_exclude.find(0) == cols_to_exclude.end()) {
// When broadcast includes column zero do not exclude anything
std::set<uint32_t> unsafe_rows = {};
Expand Down
5 changes: 4 additions & 1 deletion tests/blackhole/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ set(UNIT_TESTS_BH_SRCS

add_executable(unit_tests_blackhole ${UNIT_TESTS_BH_SRCS})
target_link_libraries(unit_tests_blackhole PRIVATE test_common)
set_target_properties(unit_tests_blackhole PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/test/umd/blackhole)
set_target_properties(unit_tests_blackhole PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/test/umd/blackhole
OUTPUT_NAME unit_tests
)

add_custom_target(umd_unit_tests DEPENDS unit_tests_blackhole)
Loading

0 comments on commit ac71e20

Please sign in to comment.