Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8364: Disable implicit fallback for ttnn.pad #8742

Merged
merged 1 commit into from
May 23, 2024
Merged

#8364: Disable implicit fallback for ttnn.pad #8742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/ttnn/unit_tests/operations/test_pad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from models.utility_functions import skip_for_wormhole_b0


@pytest.mark.skip(reason="ttnn.pad does not support row_major tensors because the kernel currently causes a PCC error")
@pytest.mark.parametrize("h", [32])
@pytest.mark.parametrize("w", [64])
@pytest.mark.parametrize("padding,torch_padding", [(((0, 1), (0, 2)), (0, 2, 0, 1)), (((1, 1), (4, 2)), (4, 2, 1, 1))])
Expand All @@ -35,6 +36,7 @@ def test_pad(device, h, w, padding, torch_padding, value):
assert_with_pcc(torch_output_tensor, output_tensor, 0.9999)


@pytest.mark.skip(reason="ttnn.pad does not support row_major tensors because the kernel currently causes a PCC error")
@pytest.mark.parametrize("h", [32])
@pytest.mark.parametrize("w", [64])
@pytest.mark.parametrize("padding,torch_padding", [(((0, 1), (0, 2)), (0, 2, 0, 1)), (((1, 1), (4, 2)), (4, 2, 1, 1))])
Expand Down Expand Up @@ -62,6 +64,7 @@ def test_pad_back_to_back(device, h, w, padding, torch_padding, value):
assert_with_pcc(torch_output_tensor, output_tensor, 0.9999)


@pytest.mark.skip(reason="ttnn.pad requires pad to start at 0")
@pytest.mark.parametrize("h", [32])
@pytest.mark.parametrize("w", [64])
@pytest.mark.parametrize("padding", [((0, 32), (0, 32)), ((1, 64), (0, 96)), ((0, 64), (0, 43)), ((32, 64), (64, 96))])
Expand Down
2 changes: 1 addition & 1 deletion ttnn/ttnn/operations/data_movement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def _pad_validate_input_tensors(operation_name, input_tensor, *args, **kwargs):
golden_function=_golden_function,
preprocess_golden_function_inputs=_preprocess_golden_function_inputs,
postprocess_golden_function_outputs=_postprocess_golden_function_outputs,
allow_to_fallback_to_golden_function_on_failure=True,
allow_to_fallback_to_golden_function_on_failure=False,
)
def pad(
input_tensor: ttnn.Tensor,
Expand Down
Loading