-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8632: Support fp32 dest acc en in moreh_sum and moreh_sum_backward #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjin-na
requested review from
TT-BrianLiu,
tt-aho and
mywoodstock
as code owners
May 22, 2024 15:02
hschoi4448
reviewed
May 22, 2024
hschoi4448
approved these changes
May 23, 2024
@tt-aho @TT-BrianLiu @mywoodstock please review/approve |
TT-BrianLiu
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the DeviceComputeKernelConfig parameter to operations like the
moreh_sum
andmoreh_sum_backward
functions. This change will allow us to provide kernel configuration settings optionally during function calls.The only applied configurations in DeviceComputeKernelConfig are
math fidelity
andfp32_dest_acc_en
.