#8721: Add forward support for lei #8722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouliraj-mcw
requested review from
umadevimcw,
ruthreshx,
bharane-ab,
VirdhatchaniKN,
Aswinmcw,
KalaivaniMCW and
mcw-anasuya
mouliraj-mcw
force-pushed
the
mouliraj/binary_lei
branch
from
00c04a5
to
fe8b5a4
Compare
tt-aho
reviewed
Aug 6, 2024
Comment on lines
395
to
403
| Tensor ExecuteBinaryLE::operator()(const Tensor& input_a, const Tensor& input_b, const std::optional<MemoryConfig>& output_mem_config) { | ||
| return ttnn::le(input_a, input_b, std::nullopt, output_mem_config, input_a); | ||
| } | ||
|
|
||
|
|
||
| Tensor ExecuteBinaryLE::operator()(const Tensor& input, float scalar, const std::optional<MemoryConfig>& output_mem_config) { | ||
| return ttnn::le(input, scalar, std::nullopt, output_mem_config, input); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why does this operation still take in output mem config when it is specifically an in place operation so output_mem_config will never actually be needed/used since it will always be the input mem config?
mouliraj-mcw
force-pushed
the
mouliraj/binary_lei
branch
3 times, most recently
from
8830e27
to
bb494e9
Compare
mouliraj-mcw
force-pushed
the
mouliraj/binary_lei
branch
from
bb494e9
to
3548522
Compare
tt-aho
approved these changes
Aug 7, 2024
mouliraj-mcw
force-pushed
the
mouliraj/binary_lei
branch
from
3548522
to
37d58f3
Compare
eyonland
requested changes
Aug 8, 2024
|
Closing this PR. It will be Handled in PR link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #8721
Add LE_ op ( less than or equal to op , in_place operation)
Test File:
tests/ttnn/unit_tests/operations/test_binary_composite.py::test_lei_ttnn- PASSEDtests/ttnn/unit_tests/operations/test_binary_composite.py::test_binary_lei_ttnn- PASSEDCI test: Link - PASSED