Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliding window ops in c++ #8693

Merged
merged 31 commits into from
May 23, 2024
Merged

sliding window ops in c++ #8693

merged 31 commits into from
May 23, 2024

Conversation

mywoodstock
Copy link
Contributor

No description provided.

@mywoodstock mywoodstock marked this pull request as ready for review May 21, 2024 19:59
arakhmati
arakhmati suggested changes May 21, 2024
View reviewed changes
ttnn/cpp/ttnn/operations/maxpool2d.hpp Outdated Show resolved Hide resolved
ttnn/cpp/ttnn/operations/conv2d.hpp Outdated Show resolved Hide resolved
ttnn/cpp/ttnn/operations/maxpool2d.hpp Outdated Show resolved Hide resolved
ttnn/ttnn/device.py Outdated Show resolved Hide resolved
ttnn/ttnn/device.py Outdated Show resolved Hide resolved
ttnn/ttnn/operations/conv2d.py Show resolved Hide resolved
ttnn/ttnn/__init__.py Outdated Show resolved Hide resolved
tt-nshanker and others added 28 commits May 23, 2024 04:01
@tt-nshanker @mywoodstock
#0: adding composite conv op and new halo op to makefile wip
0783952
@mywoodstock
#7083: config tensor generation before create_program, move to device…
a870d0b 
… in create_program

#7083: clean compile
@tt-nshanker @mywoodstock
#7083: swap with new c++ conv
6d45c00
@mywoodstock
#7083: maxpool composite in c++
e9ace46 
#7083: maxpool2d c++ macro-op pybind
#7083: new maxpool unit tests
@mywoodstock
#0: resize instead of reserve!
90f2932
@sankarmanoj-tt @mywoodstock
#7083: Build with CMake works!
b6c20e6
@sankarmanoj-tt @mywoodstock
#0: Split conv and matmul into cpp+hpp
6f6f96d
@mywoodstock
#0: some fixes
d1fae84
@arakhmati @mywoodstock
#0: updated to_weight_special_padding_tile_layout to use borrowed or …
db28eda 
…owned storage
@mywoodstock
#7083: remote config fix
3710a40 
#7083: config identical to orig version
#7083: fix broken height sharded
#7083: height sharded tests pass on GS
@sankarmanoj-tt @mywoodstock
#0: Fixed BFloat8_B for conv
27e3d0d
@arakhmati @mywoodstock
#5389: added host buffer wrapper
2218784
@sankarmanoj-tt @mywoodstock
#7083: Using ToDtype to convert BFloat8_B Bias
f606f81 
#7083: snap to tile fix
@tt-nshanker @mywoodstock
#7083: turned on all height sharded and block sharded tests
8238f14 
#7083: fixes for bias conversion. Enabled all gs unit tests. One failing only
#7083: fixes for first conv and added explicit debug mode for conv
#7083: remove dtype, cleaning
@mywoodstock
#0: disable non-RN50 tests
29acf14
@mywoodstock
#0: rebase to main, fix compile issues
d1b9ce9
@tt-nshanker @mywoodstock
#7083: 1x1 convfixes
b3f55dc
@mywoodstock
#0: disable small rn50 block test, needs to be tested with new api
49d8377
@mywoodstock
#7083: RN50 debug ongoing
5e48eff 
#7083: eltwise, handle bfp8 and others
@mywoodstock
#0: disable new version of maxpool unit tests, enable after debug
c554711
@mywoodstock
#0: b=1 not working for sd
fe8e721
@sankarmanoj-tt @mywoodstock
#7083: Removed import models.utility_function in conv2d.py
3103528 
#7083: Disabled failing tests on test_sd_conv
@sankarmanoj-tt @mywoodstock
#0: Added ResnetBlock for SD Tests
8de8a49
@mywoodstock
#0: fixing some bugs. RN50 runs e2e
10d20c3
@mywoodstock
#7083: Use device buffer instead of tensor to remove dependency from …
e6d22d1 
…tt_metal, several other minor updates
@mywoodstock
#7083: leftover dependency removal
2023b60
@mywoodstock
#7083: no need to invalidate compile
31affe7
@mywoodstock
#7083: resolved rn50 b=20 l1 issue. bad pcc with b=20, rest all good
d2ec029
@mywoodstock mywoodstock force-pushed the asarje/final-conv-cpp-refactor branch from b50fcd5 to d2ec029 Compare May 23, 2024 04:01
@mywoodstock mywoodstock merged commit c745420 into main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgkeller pgkeller pgkeller approved these changes

@tt-nshanker tt-nshanker tt-nshanker approved these changes

@tt-rkim tt-rkim tt-rkim approved these changes

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@abhullar-tt abhullar-tt abhullar-tt approved these changes

@tt-aho tt-aho tt-aho approved these changes

@arakhmati arakhmati arakhmati approved these changes

@eyonland eyonland Awaiting requested review from eyonland

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mywoodstock @arakhmati @tt-aho @abhullar-tt @TT-BrianLiu @tt-rkim @tt-nshanker @pgkeller @sankarmanoj-tt