Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8513: Add slack notifications to several more pipelines #8685

Conversation

dimitri-tenstorrent
Copy link
Contributor

Issue #8513

@dimitri-tenstorrent dimitri-tenstorrent force-pushed the dimitri/8513-add-slack-notifications-to-several-more-pipelines branch 2 times, most recently from 5dd91d5 to 553d7cd Compare May 21, 2024 17:12
@dimitri-tenstorrent dimitri-tenstorrent changed the title Add slack notifications to several more pipelines 8513: Add slack notifications to several more pipelines May 21, 2024
@dimitri-tenstorrent dimitri-tenstorrent changed the title 8513: Add slack notifications to several more pipelines #8513: Add slack notifications to several more pipelines May 21, 2024
@dimitri-tenstorrent dimitri-tenstorrent force-pushed the dimitri/8513-add-slack-notifications-to-several-more-pipelines branch 2 times, most recently from 01a8204 to 379ea2f Compare May 22, 2024 15:58
@dimitri-tenstorrent dimitri-tenstorrent force-pushed the dimitri/8513-add-slack-notifications-to-several-more-pipelines branch from 379ea2f to eefaea8 Compare May 22, 2024 17:17
Copy link
Collaborator

@TT-billteng TT-billteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

        Use `failure` instead of checking for the step condition
@dimitri-tenstorrent dimitri-tenstorrent force-pushed the dimitri/8513-add-slack-notifications-to-several-more-pipelines branch from eefaea8 to e2f8011 Compare May 23, 2024 13:46
@dimitri-tenstorrent dimitri-tenstorrent merged commit 341b3b0 into main May 23, 2024
5 checks passed
@dimitri-tenstorrent dimitri-tenstorrent deleted the dimitri/8513-add-slack-notifications-to-several-more-pipelines branch May 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants