-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to enable compile when ARCH_NAME=blackhole #8547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhullar-tt
requested review from
pgkeller,
tt-asaigal,
tt-rkim and
TT-billteng
as code owners
May 16, 2024 03:46
Let us know when it's ready for review Don't forget to add build jobs for Blackhole |
abhullar-tt
commented
May 16, 2024
abhullar-tt
force-pushed
the
abhullar/bh-compile
branch
from
May 16, 2024 16:04
e852264
to
599d481
Compare
pgkeller
approved these changes
May 16, 2024
abhullar-tt
changed the title
WIP Support to enable compile when ARCH_NAME=blackhole
Support to enable compile when ARCH_NAME=blackhole
May 16, 2024
abhullar-tt
force-pushed
the
abhullar/bh-compile
branch
from
May 16, 2024 17:18
599d481
to
5a803da
Compare
abhullar-tt
force-pushed
the
abhullar/bh-compile
branch
from
May 16, 2024 17:38
5a803da
to
c2c388f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables compile to pass when ARCH_NAME=blackhole
It also includes getting latest UMD changes to support blackhole