Add ninja as a metal dependency #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT-billteng
force-pushed
the
bteng/ninjadep
branch
from
fb30e61
to
47c1520
Compare
tt-rkim
reviewed
May 9, 2024
TT-billteng
force-pushed
the
bteng/ninjadep
branch
from
47c1520
to
0d30201
Compare
TT-billteng
force-pushed
the
bteng/ninjadep
branch
from
0d30201
to
db64b72
Compare
TT-billteng
force-pushed
the
bteng/ninjadep
branch
from
db64b72
to
90f1746
Compare
TT-billteng
added a commit
that referenced
this pull request
May 13, 2024
TT-billteng
added a commit
that referenced
this pull request
May 13, 2024
TT-billteng
force-pushed
the
bteng/ninjadep
branch
from
90f1746
to
a0ff976
Compare
tt-rkim
approved these changes
May 13, 2024
TT-billteng
force-pushed
the
bteng/ninjadep
branch
from
a0ff976
to
12f958b
Compare
vtangTT
added a commit
that referenced
this pull request
May 14, 2024
vtangTT
added a commit
that referenced
this pull request
May 14, 2024
vtangTT
added a commit
that referenced
this pull request
May 14, 2024
vtangTT
added a commit
that referenced
this pull request
May 14, 2024
vtangTT
added a commit
that referenced
this pull request
May 14, 2024
TT-billteng
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 6944d12.
TT-billteng
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 6944d12.
TT-billteng
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit 83fcbf3.
TT-billteng
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit 83fcbf3.
TT-billteng
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit 83fcbf3.
ihamer-tt
pushed a commit
that referenced
this pull request
May 15, 2024
ihamer-tt
pushed a commit
that referenced
this pull request
May 15, 2024
This reverts commit 6944d12.
ihamer-tt
pushed a commit
that referenced
this pull request
May 15, 2024
This reverts commit 83fcbf3.
ttmchiou
pushed a commit
that referenced
this pull request
May 16, 2024
This reverts commit 83fcbf3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake + make should still work, but ninja is better
CMake + ninja is about 15% faster than CMake + make on my BM
On a VM, CMake + ninja is about 5% faster.