#6938: Implement softplus as a single kernel #8249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmalTT
force-pushed
the
esmal/softplus
branch
14 times, most recently
from
7aa78e1
to
50c79d5
Compare
esmalTT
force-pushed
the
esmal/softplus
branch
7 times, most recently
from
04a5331
to
453df35
Compare
TT-BrianLiu
approved these changes
May 31, 2024
rtawfik01
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert composite
softplusoperation to a single kernel implementation to improve performance.Previously, the composite version of
softplustook 0.15 ms for an input shape of(32, 32, 5120). After this change, the same input shape now takes approx. 0.01 ms.Due to problems with register pressure in the GS implementation of this kernel, we have decided to remove support for that architecture in this PR. Because
mishusessoftplusinternally, it will also no longer be supported on Grayskull. I will open an issue to track this regression.Blocking issues:
EltwiseUnary#8398Closes #6938