Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4836: Add support for blocking conv activation in 2d systolic conv v… #4837

Merged
merged 1 commit into from
Jan 25, 2024
Merged

#4836: Add support for blocking conv activation in 2d systolic conv v… #4837

merged 1 commit into from
Jan 25, 2024
+287 −158

Conversation

tt-nshanker
Copy link
Contributor

…ariant

@tt-nshanker tt-nshanker marked this pull request as ready for review January 25, 2024 01:53
TT-BrianLiu
TT-BrianLiu approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@TT-BrianLiu TT-BrianLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fix the minor comment in the compute kernel

tt_eager/tt_dnn/op_library/conv/kernels/conv_bmm_tilize_col_major_out_blocks.cpp Outdated
Comment on lines 177 to 179
#ifdef SFPU_OP_INIT_ACTIVATION
SFPU_OP_INIT_ACTIVATION
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be outside the loops. It's not part of the pre-tilize block.

@tt-nshanker
Copy link
Contributor Author

CI - https://github.com/tenstorrent-metal/tt-metal/actions/runs/7648820942

@tt-nshanker tt-nshanker merged commit 38659f6 into main Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@mywoodstock mywoodstock mywoodstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tt-nshanker @mywoodstock @TT-BrianLiu @tt-rkim