-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#0: update allocator search option and leak check #4457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI tests passing: https://github.com/tenstorrent-metal/tt-metal/actions/runs/7281613755 |
muthutt
force-pushed
the
ma/newloc
branch
2 times, most recently
from
January 30, 2024 22:57
418fc60
to
7289081
Compare
: fix the allocator best search strategy which had a bug - it was same as first search strategy
@abhullar-tt - lets chat sometime this week with intention to handoff this branch (or find a way to move conversation) and until then I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#0: update allocator search option and leak check
: fix the allocator best search strategy which had a bug - it was same as first search strategy
: fix memory leak (assign on std::make_unique() should ideally use std::move() or reset(new T(...)) etc.)
Valgrind report on test, (python_env) ~/tt-metal-concat$ valgrind --leak-check=full ./build/test/tt_metal/test_reduce_h shows:
The fixed version shows leak as,