Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npetrovic/float8 unit tests #4206

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Npetrovic/float8 unit tests #4206

merged 7 commits into from
Jan 16, 2024

Conversation

npetrovic-tenstorrent
Copy link
Contributor

Additional bfloat8 unit tests for low PCC operations.

@npetrovic-tenstorrent npetrovic-tenstorrent added the feature-request External feature request label Dec 6, 2023
@npetrovic-tenstorrent npetrovic-tenstorrent self-assigned this Dec 6, 2023
@npetrovic-tenstorrent npetrovic-tenstorrent linked an issue Dec 6, 2023 that may be closed by this pull request
Additional bfloat8 unit tests #4205
Closed
nemanjagrujic
nemanjagrujic reviewed Dec 7, 2023
View reviewed changes
tests/tt_eager/python_api_testing/non_working_unit_tests/grayskull/test_bfloat8_layernorm.py Outdated
if in_mem_config[2] == "SYSTEM_MEMORY":
in_mem_config[2] = None

print(in_mem_config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print

nemanjagrujic
nemanjagrujic reviewed Dec 7, 2023
View reviewed changes
...ager/python_api_testing/non_working_unit_tests/grayskull/test_bfloat8_layernorm_noweights.py Outdated
if in_mem_config[2] == "SYSTEM_MEMORY":
in_mem_config[2] = None

print(in_mem_config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@npetrovic-tenstorrent npetrovic-tenstorrent merged commit 471f321 into main Jan 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt-aho tt-aho tt-aho approved these changes

@nemanjagrujic nemanjagrujic nemanjagrujic approved these changes

Assignees

@npetrovic-tenstorrent npetrovic-tenstorrent

Labels
feature-request External feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional bfloat8 unit tests
3 participants
@npetrovic-tenstorrent @nemanjagrujic @tt-aho