Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4176: uplift umd to include create-eth-map fixes #4195

Merged
merged 2 commits into from
Dec 6, 2023
Merged

#4176: uplift umd to include create-eth-map fixes #4195

merged 2 commits into from
Dec 6, 2023

Conversation

aliuTT
Copy link
Contributor

@aliuTT aliuTT commented Dec 5, 2023

No description provided.

@aliuTT
Copy link
Contributor Author

aliuTT commented Dec 5, 2023

fyi @DrJessop @abhullar-tt

@aliuTT
Copy link
Contributor Author

aliuTT commented Dec 6, 2023

@abhullar-tt I thought about it some more, we will need to assert all deasserted workers on device close. That way we can allow individual devices to close by themselves.

@aliuTT aliuTT merged commit 3b081a5 into main Dec 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhullar-tt abhullar-tt abhullar-tt left review comments

@TT-billteng TT-billteng TT-billteng approved these changes

@tt-rkim tt-rkim Awaiting requested review from tt-rkim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliuTT @abhullar-tt @TT-billteng