-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3932: Rename unary op args which were input_a -> input, binary ops from input, other -> input_a, input_b #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-aho
force-pushed
the
aho/arg-rename
branch
2 times, most recently
from
December 7, 2023 21:35
ff38868
to
3783ddf
Compare
tt-aho
force-pushed
the
aho/arg-rename
branch
from
December 7, 2023 23:44
3783ddf
to
7821641
Compare
tt-aho
requested review from
TT-BrianLiu,
arakhmati and
mywoodstock
as code owners
December 8, 2023 23:04
TT-BrianLiu
approved these changes
Dec 9, 2023
…rom input, other -> input_a, input_b
tt-aho
force-pushed
the
aho/arg-rename
branch
from
December 9, 2023 00:34
7821641
to
ca32d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.