Opt LN_sharded and SMX_sharded #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yugaoTT
commented
Dec 2, 2023
yugaoTT
commented
- for SMX, remove wait_front to avoid unpacker packer sync
- for LN, finished compute for one block in one run before switching to another compute section.
farbabi
suggested changes
Dec 5, 2023
| @@ -171,7 +171,7 @@ def test_perf_virtual_machine( | |||
| @pytest.mark.models_performance_bare_metal | |||
| @pytest.mark.parametrize( | |||
| "expected_inference_time, expected_compile_time, inference_iterations", | |||
| ([0.0375, 10, 10],), | |||
| ([0.0364, 10, 10],), | |||
There was a problem hiding this comment.
To tighten inference time tolerance, please run the model 3 times on CI and average the inference time and consider 15% tolerance.
There was a problem hiding this comment.
Thanks for the advice, I have ran it for 3 times and passed with fps ~338
There was a problem hiding this comment.
Hey @farbabi, if there is no other things needs change/test, could I get an approval? thanks
|
@boris-drazic just a reminder that the PR needs your approval :). I'd appreciate it if you can take a look at the changes |
boris-drazic
approved these changes
Dec 6, 2023
farbabi
approved these changes
Dec 7, 2023
yugaoTT
force-pushed
the
BERT_large_sharded
branch
from
65447a0
to
3eb0ec7
Compare
yugaoTT
force-pushed
the
BERT_large_sharded
branch
from
3eb0ec7
to
cbe97c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.