Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2408: Separate profiler regression from post commit #2410

Merged
merged 0 commits into from
Sep 1, 2023

Conversation

mo-tenstorrent
Copy link
Contributor

No description provided.

@mo-tenstorrent mo-tenstorrent added the performance monitoring Feature or bug related to performance monitoring label Aug 31, 2023
@mo-tenstorrent mo-tenstorrent self-assigned this Aug 31, 2023
@mo-tenstorrent mo-tenstorrent requested a review from tt-rkim as a August 31, 2023 18:19
@mo-tenstorrent mo-tenstorrent temporarily deployed to dev August 31, 2023 18:25 — with GitHub Actions Inactive
@mo-tenstorrent mo-tenstorrent force-pushed the mo/2408_seperate_out_profiler_regression branch from f34f84c to 45de364 Compare August 31, 2023 18:37
@mo-tenstorrent mo-tenstorrent temporarily deployed to dev August 31, 2023 18:37 — with GitHub Actions Inactive
@mo-tenstorrent
Copy link
Contributor Author

https://github.com/tenstorrent-metal/tt-metal/actions/runs/6041189375 Profiler pass
https://github.com/tenstorrent-metal/tt-metal/actions/runs/6040969757 Post commit pass

@mo-tenstorrent mo-tenstorrent force-pushed the mo/2408_seperate_out_profiler_regression branch from 3373b71 to f30f3c9 Compare August 31, 2023 19:09
@mo-tenstorrent mo-tenstorrent changed the title #2408: Seperated profiler regressiong from post commit #2408: Separate profiler regression from post commit Aug 31, 2023
@tt-rkim
Copy link
Collaborator

tt-rkim commented Aug 31, 2023

Spelled make_porfiler_build.sh wrong

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in file name? should be profiler

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also name the script build_profiler.sh? The reasoning is that the other scripts are run_ .sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah will do

@mo-tenstorrent mo-tenstorrent force-pushed the mo/2408_seperate_out_profiler_regression branch 3 times, most recently from 0789a5d to c292ad3 Compare August 31, 2023 19:31
@mo-tenstorrent mo-tenstorrent temporarily deployed to dev August 31, 2023 19:31 — with GitHub Actions Inactive
@mo-tenstorrent
Copy link
Contributor Author

https://github.com/tenstorrent-metal/tt-metal/actions/runs/6041651242/job/16395074448 Profiler reg. pass after file name changes

Copy link
Collaborator

@TT-billteng TT-billteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mo-tenstorrent mo-tenstorrent force-pushed the mo/2408_seperate_out_profiler_regression branch from c292ad3 to f490f7f Compare September 1, 2023 14:19
@mo-tenstorrent mo-tenstorrent temporarily deployed to dev September 1, 2023 14:20 — with GitHub Actions Inactive
@mo-tenstorrent mo-tenstorrent merged this pull request into main Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance monitoring Feature or bug related to performance monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants