Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default use_multicore to true everywhere #15076

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −20
Draft

Default use_multicore to true everywhere #15076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ttnn/cpp/ttnn/operations/data_movement/pad/pad_pybind.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -102,7 +102,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -122,7 +122,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -142,7 +142,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -162,7 +162,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -182,7 +182,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -202,7 +202,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
},
Expand All @@ -222,7 +222,7 @@ void bind_pad(py::module& module) {
py::arg("input_tensor_start"),
py::arg("value"),
py::kw_only(),
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("queue_id") = 0,
}
Expand Down
4 changes: 2 additions & 2 deletions ttnn/cpp/ttnn/operations/data_movement/tilize/tilize.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ struct ExecuteTilize {
const ttnn::Tensor &input_tensor,
const std::optional<MemoryConfig> &memory_config = std::nullopt,
std::optional<DataType> output_dtype = std::nullopt,
bool use_multicore = false);
bool use_multicore = true);

static ttnn::Tensor invoke(
const ttnn::Tensor &input_tensor,
const std::optional<MemoryConfig> &memory_config = std::nullopt,
std::optional<DataType> output_dtype = std::nullopt,
bool use_multicore = false);
bool use_multicore = true);
};

} // namespace operations::data_movement
Expand Down
8 changes: 4 additions & 4 deletions ttnn/cpp/ttnn/operations/data_movement/tilize_with_val_padding/tilize_with_val_padding.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ struct ExecuteTilizeWithValPadding {
const PadValue pad_value,
const std::optional<MemoryConfig> &memory_config = std::nullopt,
std::optional<DataType> output_dtype = std::nullopt,
bool use_multicore = false);
bool use_multicore = true);

static ttnn::Tensor invoke(
const ttnn::Tensor &input_tensor,
const tt::tt_metal::LegacyShape &output_tensor_shape,
const PadValue pad_value,
const std::optional<MemoryConfig> &memory_config = std::nullopt,
std::optional<DataType> output_dtype = std::nullopt,
bool use_multicore = false);
bool use_multicore = true);

};

Expand All @@ -41,13 +41,13 @@ struct ExecuteTilizeWithZeroPadding {
const ttnn::Tensor &input_tensor,
const std::optional<MemoryConfig> &memory_config = std::nullopt,
std::optional<DataType> output_dtype = std::nullopt,
bool use_multicore = false);
bool use_multicore = true);

static ttnn::Tensor invoke(
const ttnn::Tensor &input_tensor,
const std::optional<MemoryConfig> &memory_config = std::nullopt,
std::optional<DataType> output_dtype = std::nullopt,
bool use_multicore = false);
bool use_multicore = true);
};

} // namespace operations::data_movement
Expand Down
4 changes: 2 additions & 2 deletions .../ttnn/operations/data_movement/tilize_with_val_padding/tilize_with_val_padding_pybind.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void bind_tilize_with_val_padding(py::module &module) {
py::kw_only(),
py::arg("memory_config") = std::nullopt,
py::arg("dtype") = std::nullopt,
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("queue_id") = 0,
}

Expand Down Expand Up @@ -105,7 +105,7 @@ void bind_tilize_with_zero_padding(py::module &module) {
py::kw_only(),
py::arg("memory_config") = std::nullopt,
py::arg("output_dtype") = std::nullopt,
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("queue_id") = 0,
});
}
Expand Down
4 changes: 2 additions & 2 deletions ttnn/cpp/ttnn/operations/data_movement/untilize_with_unpadding/untilize_with_unpadding.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ struct ExecuteUntilizeWithUnpadding {
const ttnn::Tensor &input_tensor,
const tt::tt_metal::LegacyShape &output_tensor_end,
const std::optional<MemoryConfig> &memory_config,
bool use_multicore = false,
bool use_multicore = true,
bool use_pack_untilize = true);

static ttnn::Tensor invoke(
const ttnn::Tensor &input_tensor,
const tt::tt_metal::LegacyShape &output_tensor_end,
const std::optional<MemoryConfig> &memory_config,
bool use_multicore = false,
bool use_multicore = true,
bool use_pack_untilize = true);
};

Expand Down
2 changes: 1 addition & 1 deletion .../ttnn/operations/data_movement/untilize_with_unpadding/untilize_with_unpadding_pybind.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ void bind_untilize_with_unpadding(py::module &module) {
py::arg("output_tensor_end"),
py::kw_only(),
py::arg("memory_config") = std::nullopt,
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("use_pack_untilize") = true,
py::arg("queue_id") = 0,
});
Expand Down
2 changes: 1 addition & 1 deletion ttnn/cpp/ttnn/operations/reduction/argmax/argmax_pybind.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void bind_reduction_argmax_operation(py::module& module) {
py::arg("input_tensor").noconvert(),
py::kw_only(),
py::arg("dim") = std::nullopt,
py::arg("use_multicore") = false,
py::arg("use_multicore") = true,
py::arg("memory_config") = std::nullopt,
py::arg("output_tensor") = std::nullopt,
py::arg("queue_id") = 0});
Expand Down
Loading