Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update size.hpp #15072

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Update size.hpp #15072

merged 5 commits into from
Nov 15, 2024

Conversation

blozano-tt
Copy link
Contributor

@blozano-tt blozano-tt commented Nov 15, 2024

Problem description

Fix spurrious compiler error seen by @afuller-TT

/home/ubuntu/actions-runner/_work/tt-metal/tt-metal/ttnn/cpp/ttnn/tensor/layout/size.hpp:30:50: error: 'forward_as_tuple' is not a member of 'std'
   30 |     static constexpr auto attribute_names = std::forward_as_tuple("height", "width");
/home/ubuntu/actions-runner-2/_work/tt-metal/tt-metal/ttnn/cpp/ttnn/tensor/layout/size.hpp:14:26: error: 'size_t' was not declared in this scope; did you mean 'std::size_t'?
   14 |     Size(const std::pair<size_t, size_t>& size);
      |                          ^~~~~~
      |                          std::size_t
In file included from /usr/include/c++/12/type_traits:38,
                 from /usr/include/c++/12/concepts:44,
                 from /usr/include/c++/12/compare:39,
                 from /usr/include/c++/12/array:38,
                 from /home/ubuntu/actions-runner-2/_work/tt-metal/tt-metal/ttnn/cpp/ttnn/tensor/layout/size.hpp:7:
/usr/include/x86_64-linux-gnu/c++/12/bits/c++config.h:298:33: note: 'std::size_t' declared here
  298 |   typedef __SIZE_TYPE__         size_t;

What's changed

Include what you use, fully qualify std::

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@blozano-tt blozano-tt merged commit f80104c into main Nov 15, 2024
9 checks passed
@blozano-tt blozano-tt deleted the blozano-tt-patch-3 branch November 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants