Remove firmware dependency on generated_bank_to_noc_coord_mapping.h #15070
+137
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the global arrays from generated_bank_to_noc_coord_mapping.h to brisc.cc and ncrisc.cc For Kernel, this global arrays are declared as extern in dataflow_api.h Allocate space in L1 for the host to copy array data during build. Firmware would then copy this data to the global array during init.
spoojaryTT
force-pushed
the
spoojary/fw-dependency
branch
from
ac2686a
to
a1c797a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
12844
Problem description
Firmware build is dependent on runtime values.
What's changed
Firmware now declares a global array for dram_bank_to_noc_xy, l1_bank_to_noc_xy, bank_to_dram_offset, bank_to_l1_offset. During build, values are written to L1 memory. Firmware during initialization would copy these values from L1 to the above global arrays.
Checklist