Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(REDO) Reduce dependence on ARCH_NAME in dev_msgs.h #15068

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(REDO) Reduce dependence on ARCH_NAME in dev_msgs.h #15068

wants to merge 2 commits into from
+63 −35

Conversation

blozano-tt
Copy link
Contributor

@blozano-tt blozano-tt commented Nov 14, 2024 •
edited
Loading

Problem description

kernel compiles were failing

What's changed

Ensure dev_mem_map.h and noc_parameters.h is included in any FW or KERNEL TU.

Checklist

https://github.com/tenstorrent/tt-metal/actions/runs/11848347505

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhullar-tt abhullar-tt abhullar-tt approved these changes

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blozano-tt @abhullar-tt