#13655: Fix sub-device tests for BH #15050
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-aho
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-asaigal
approved these changes
Nov 14, 2024
Was not accounting for alignment when calculating expected addresses
…d perf above the threshold, instead of only failing when perf is lower so that we can keep the golden values up to date Update golden values with latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not accounting for alignment when calculating expected addresses
Problem description
BH tests were failing addr checks.
What's changed
Use aligned pages size when calculating addrs
Checklist