Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dst_full_sync_en flag in the WH compute kernel config pybind #15007

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support dst_full_sync_en flag in the WH compute kernel config pybind #15007

wants to merge 1 commit into from

Conversation

avoraTT
Copy link
Contributor

@avoraTT avoraTT commented Nov 13, 2024

Ticket

Problem description

A previous PR added support for full dst mode. However, it did not update the WormholeComputeKernelConfig pybind to reflect this change.

What's changed

This PR adds the dst_full_sync_en flag to the WormholeComputeKernelConfig pybind.

Checklist

  • Post commit CI passes

@avoraTT avoraTT mentioned this pull request Nov 13, 2024
Draft
5 tasks
@amahmudTT
Copy link
Contributor

Could you add the link of all post commit tests passing here ?

@avoraTT
Copy link
Contributor Author

avoraTT commented Nov 13, 2024

Post-commit: https://github.com/tenstorrent/tt-metal/actions/runs/11825640591

@amahmudTT
Copy link
Contributor

Post-commit: https://github.com/tenstorrent/tt-metal/actions/runs/11825640591

I think some tests are failing, but not because of this change, you could try to rerun the failing tests only. Once they pass I can approve. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amahmudTT amahmudTT Awaiting requested review from amahmudTT

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt will be requested when the pull request is marked ready for review ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt will be requested when the pull request is marked ready for review dmakoviichuk-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu will be requested when the pull request is marked ready for review cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu will be requested when the pull request is marked ready for review TT-BrianLiu is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avoraTT @amahmudTT