Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13676: Add unit tests for io_bw, tan_bw, and lerp #15002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#13676: Add unit tests for io_bw, tan_bw, and lerp #15002

wants to merge 1 commit into from
+412 −426

Conversation

nemanjagrujic
Copy link
Contributor

  • Add unit tests for io_bw, tan_bw, and lerp problems.
  • Deleted some invalid unit tests.

rfurko-tt
rfurko-tt approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@rfurko-tt rfurko-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

tests/ttnn/python_api_testing/non_working_unit_tests/wormhole/test_eltwise_i0_bw.py
def test_eltwise_i0_bw(input_shape, dtype, dlayout, in_mem_config, out_mem_config, data_seed, device):
random.seed(0)

[pcc, e2e_perf] = run_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write unpacking this way
(passed, pcc_value), e2e_perf = run_test

tests/ttnn/python_api_testing/non_working_unit_tests/wormhole/test_eltwise_i0_bw.py
)
[passed, pcc_value] = pcc

assert passed, f"pcc={pcc[1]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use unpacked value pcc_value

tests/ttnn/python_api_testing/non_working_unit_tests/wormhole/test_eltwise_lerp.py
)
[passed, pcc_value] = pcc

assert passed, f"pcc={pcc[1]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use pcc_value in assert

tests/ttnn/python_api_testing/non_working_unit_tests/wormhole/test_eltwise_tan_bw.py
)
[passed, pcc_value] = pcc

assert passed, f"pcc={pcc[1]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfurko-tt rfurko-tt rfurko-tt approved these changes

@dmakoviichuk-tt dmakoviichuk-tt dmakoviichuk-tt approved these changes

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@boris-drazic boris-drazic boris-drazic approved these changes

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nemanjagrujic @boris-drazic @TT-BrianLiu @dmakoviichuk-tt @rfurko-tt